drupalwxt/helm-drupal

Ability to keep last install/upgrade job pods

bernardmaltais opened this issue · 4 comments

bernardmaltais commented

I have had many occurrence where Drupal upgrade goes failing due to some issue with drush cim or drush updb. The current job will be deleted after 5 failed execution. Would it be possible to retain the last job pod to facilitate log reviews? I think the parameter for that might be:

  annotations:
    "helm.sh/hook": post-upgrade
    "helm.sh/hook-weight": "10"
    "helm.sh/hook-delete-policy": hook-succeeded

to

  annotations:
    "helm.sh/hook": post-upgrade
    "helm.sh/hook-weight": "10"
    "helm.sh/hook-delete-policy": before-hook-creation

What do you think? Possibility?

sylus commented

I think this looks fine, would you be able to make a P.R?

@zachomedia any comments?

bernardmaltais commented

OK, I will create a quick PR.

bernardmaltais commented

Created PR #90

I added the option to the install and upgrade of both Drupal 7 and Drupal 9.

Tested local system and it appear to work as intended.

sylus commented

Merged :) Thanks so much in improving this chart for everyone!