ds300/patch-package

Failed to apply patch for package react-native-agora

Khubaib-Sarfraz opened this issue · 3 comments

Im using react-native-agora@4.2.0 and because of some issue in in agora i used patch-package@8.0.0

so i'm getting this issue only with 'yarn' not with the npm another solution with for this issue is to deprecate the patch-package to 7.0.2

the point where this error occurs is that when i try to install a new library in my project then this error appears and delete all my changes for the node-modules

hope you guy'z resolved this with new version '8.0.0'

ERROR Failed to apply patch for package react-native-agora at path

node_modules/react-native-agora

This error was caused because patch-package cannot apply the following patch file:

patches/react-native-agora+4.2.0.patch

Try removing node_modules and trying again. If that doesn't work, maybe there was
an accidental change made to the patch file? Try recreating it by manually
editing the appropriate files and running:

patch-package react-native-agora

If that doesn't work, then it's a bug in patch-package, so please submit a bug
report. Thanks!

https://github.com/ds300/patch-package/issues

patch-package finished with 1 error(s).

ptim commented

FYI I'm hitting a similar issue attempting to apply a patch to react-dropzone after upgrading patch-package from 7.0.0 to 8.0.0.

This is the patch that has previously worked:
react-dropzone/react-dropzone#1259 (comment)

I note the mention:

I removed some really old legacy filename handling stuff so it's technically a breaking change.

https://github.com/ds300/patch-package/releases/tag/v8.0.0

I don't need multi-patches atm, so can stay on v7.

I'm supecting the very same thing, v8 broke something.

angular/angular#56347 can attest, the patch doesn't apply anymore even if it is recreated from scratch.

Downgrading to v7 also fixed the issue for me on another library failing to apply the patch. The odd thing is that on my local machine works but not on CD. Sharing the patch in case helpful (using patch-package@8.0.0):

jsonschema+1.4.1.patch

diff --git a/node_modules/jsonschema/lib/index.d.ts b/node_modules/jsonschema/lib/index.d.ts
index ba47f9e..535d4e5 100644
--- a/node_modules/jsonschema/lib/index.d.ts
+++ b/node_modules/jsonschema/lib/index.d.ts
@@ -95,6 +95,10 @@ export interface Schema {
     if?: Schema
     then?: Schema
     else?: Schema
+    // https://github.com/tdegrunt/jsonschema/issues/394
+    default?: any
+    // https://github.com/tdegrunt/jsonschema/issues/323
+    contains?: Schema
 }
 
 export interface Options {