ds300/react-native-typescript-transformer

Note on allowSyntheticDefaultImports

henrikra opened this issue ยท 8 comments

In readme it reads:

This is neccessary until TypeScript implements suport for synthetic default imports in emitted code as well as in the type checker. See microsoft/TypeScript#9562.

That issue is now closed so I guess the README should change too?

ds300 commented

Yes, thanks for the reminder! First I'll update the transformer to be able to run without babel if TS is >= 2.7

ds300 commented

update on this: Last night I ripped out the babel transform, and ran in to this issue: microsoft/TypeScript#21621

Once that bug is solved I'll be happy to release react-native-typescript-transformer 2.0 which won't use babel at all and will only support React Native >= 0.52

wip branch over here: https://github.com/ds300/react-native-typescript-transformer/tree/no-babel

Sounds good!

@ds300 Looks like the issue is closed? So we are getting rid of babel now? :O

ds300 commented

So so close! :D

Just need to wait for TS 2.9 to drop. Should be any day now ๐Ÿคž

What a roller coaster.

  • Babel 7 will support TS! ๐Ÿ˜ฎ ๐ŸŽˆ๐ŸŽ‰
  • but not all of it ๐Ÿ˜ญ ๐Ÿ’ฅ
  • Hey, let's remove babel! ๐Ÿ˜ฎ ๐ŸŽˆ๐ŸŽ‰
  • But we can't cuz of a TS bug. ๐Ÿ˜ข ๐Ÿ’ฅ
  • It's fixed!: ๐Ÿ˜ฎ ๐ŸŽˆ๐ŸŽ‰
  • but we have to wait for 2.9 ๐Ÿ˜ช๐Ÿ’ฅ

You're killing me here David.

ds300 commented

https://twitter.com/typescriptlang/status/1002230349521338368?s=19

๐ŸŽŠ๐Ÿ’ƒ๐Ÿ•บ๐ŸŽ‰

Unfortunately I'm busy with non-tech stuff for a few days, but I'll work on a new release ASAP.

hey @ds300 , how's the 2.0 coming along? Honestly I'm just unsure if I should set "module": "es2015" in tsconfig or not, based on the info in the README.