dsavransky/EXOSIMS

calculate_dV in SotoStarShade : Conflicts in input , docstring and usage in minimize SlewTimes

Opened this issue · 0 comments

  • calculate_dV method is called with less number of inputs in minimize_slewTimes. (for ex angular sep is not given as input)
  • The order of inputs also appears to be flipped in respect to the definition of the method
  • The inputs in calculate_dV don't match with the docstring
  • Internally in minimize_slewTimes the slewTime is given as output without proper units (d) which causes error in calculate_dV
  • calculate_dV fails to take in a single pair of targets (2 stars) and corresponding single slewTime.

Most of these errors can be checked visually, using SotoStarshade observatory module in a simulation should provide the same error.

Expected behavior
Minimizing slewTime based on constraint equations.

EXOSIMS version:

  • Current master branch ( v 3.13) contains the module with this error.