Closure Compiler Advanced Optimizations

[semmypurewal]

Hi! Thanks so much for Clarinet -- it's a great project!

We're including it as part of a build that is being minified with the Google Closure Compiler using the ADVANCE_OPTIMIZATIONS option. There are a few minor code changes I had to make to get it to work, and I have the minified version passing the unit tests.

I'm not sure if this particular use-case warrants a pull request, but I thought I'd share just in case it's useful for anyone else. It's in the closure-compiler-advanced-optimizations branch on my fork.

https://github.com/semmypurewal/clarinet/tree/closure-compiler-advanced-optimizations

Thanks again!

[dscape]

Have you run the performance benchmarks against it?

• http://nunojob.com/clarinet---sax-based-evented-streaming-json-parser-in-javascript

Would can you link your branch here? :)

Thanks for opening this, I'm sure it will be immensely helpfully for people trying to do the same thing. If you have ideas on how I can integrate into the main project please do let me know

[semmypurewal]

I added the link above. I haven't tried the performance benchmarks, yet, but I'll see if I can check them in the next day or so.

The changes aren't huge, so you could probably integrate them pretty easily, but maintaining compatibility with advanced opts in the closure compiler can be a challenge. You may need to minify and run the tests after changes.

After I check the benchmarks I'll let you know.

Thank you!