Rename module and resource, removing 'x'
johlju opened this issue · 7 comments
@johlju I am willing to help with this. Was wondering if there are any references to make this change. Is it just changing the resource's name with all the information that references Exchange? Let me know. will get a PR started so we can have a discussion on it.
Awesome! All files, folders and code that has x<ResourceName> or x<ModuleName> should have the 'x' removed.
I put together a gist (haven't have time to create a blog article): https://gist.github.com/johlju/1d812a8ebcf3b10782d9ad32ad76a8af
It is always a good step to first make sure the repository is using the latest Sampler files (build & test pipeline files). But can be a bit tricky since one must check the diff of each "configuration" file to make sure nothing importan gets removed. I could help with this this weekend, so you can focus on renaming the module (step 6 in the gist above). Sound good?
New module name would be ExchangeDsc. So xExchange to ExchangeDsc.
I have fixed step 1 in PR #487, wasn't much to do since it was already updated recently.
@johlju sorry it took me this long. I have created a PR on this. Let me know what you think.
No worries. I'm a bit busy at work at the moment but will revie as soon it is possible.