Fix tests
dsgibbons opened this issue · 4 comments
dsgibbons commented
Problem
The tests run by GitHub actions always fail. There appear to be multiple failures that contribute to this. Individual issues will be raised regarding each failure condition.
Success criterion
Refactor the code, dependencies and tests so that all tests run successfully.
connortann commented
I think we're most of the way there now, just some matplotlib issues to sort.
I had a go reproducing the failing image diff tests locally (tests.plots.test_heatmap): it looks like the heatmap plot is now currently being plotted a bit vertically lower in the figure:
dsgibbons commented
Oh I was literally just working on this! I'm about to open a PR
connortann commented
@thatlittleboy I think the waterfall plot tests are not fully fixed (from #62), as they still fail on python 3.7.