dsuarezv/mavlink.net

Deserialize and Serialize are not in the right byte order for message definitions.

BTBlueSkies opened this issue · 0 comments

I have noticed in the generated messages the deserialize and serialize methods do not decode/encode the byte stream correctly. The field order is not right.

I will try to fix this.


Update:
Well, it looks like there is this sorting feature in the packed byte stream. I personally think it's a bit odd that they would do this as just defining the specification using this 'sorted by field size' would have achieved the same results and would have been cleaner to communicate. The CRC check on field order would have achieved the same goal to make sure the fields were in the right order, any defined order, but in any case, the fields should be implemented in the right order to begin with inside the specification.

Good code btw.. works fine.