dtcenter/MET

Enhance MET to make warnings messages about time differences configurable

Closed this issue · 0 comments

Describe the Enhancement

This issue was requested by @MarcelCaron-NOAA via discussion dtcenter/METplus#2472. As of MET version 11.1.0, the MET Grid-Stat tool prints a warning message if the valid time of the forecast and observation data being compared differs at all:

WARNING: process_scores() -> Forecast and observation valid times do not match 20240123_150000 != 20240123_150038 for REFC/L0 versus MergedReflectivityQCComposite/Z500.

In this example, the data differs by only 38 seconds which is not considered a problem. Small time differences are especially common with radar-derived products and also occur with satellite datasets, among others.

The METplus Python wrappers provide the functionality to search a time window for files with timestamps that are "close-enough". Since METplus is providing this data with nearly identical timestamps to Grid-Stat, Grid-Stat should not print a warning message in this case.

For this issue...

  • Add a new configuration option in ConfigConstants to define the maximum allowable time difference for which no warning message should be written.
  • Update Grid-Stat, and all other tools which write such a warning message, to only print a warning message if the tolerance is exceeded. If the timestamps differ at all, do write a DEBUG(3) log message, just no WARNING.
  • Update the contents of the warning message to tell users how they it be silenced with this new config option.

Time Estimate

1 day.

Sub-Issues

Consider breaking the enhancement down into sub-issues.
None needed.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Review default alert labels
  • Select component(s)
  • Select priority
  • Select requestor(s)

Milestone and Projects

  • Select Milestone as the next official version or Backlog of Development Ideas
  • For the next official version, select the MET-X.Y.Z Development project

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next official version
    Select: MET-X.Y.Z Development project for development toward the next official release
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.