dtcenter/MET

Enhance Ensemble-Stat and Gen-Ens-Prod to omit warning messages for the `MISSING` keyword

JohnHalleyGotway opened this issue · 1 comments

JohnHalleyGotway commented

Describe the Enhancement

This issue was discussed during the METplus NOAA User Telecon on April 29, 2024. EVS version 1 has resulted in several NCO bugzilla reports and many are related to EVS configurations triggering warning messages from MET. This issue is to fix one such warning message.

The METplus Gen-Ens-Prod and Ensemble-Stat wrappers include logic for handling missing data. When constructing the input file list for those tools, the wrappers use the keyword MISSING to indicate that the input file does not exist. As of MET-11.1.0, that triggers the following warning message to be written by MET:

WARNING: process_command_line() -> can't open input ensemble file: MISSING

Note that METplus can either use the keyword MISSING by itself or append some relevant path information MISSING/relevant/path/information. Update these tools so that when the input file does not exist but the path begins with MISSING, a debug log message is written instead of a warning.

Time Estimate

1 hour?

Sub-Issues

Consider breaking the enhancement down into sub-issues.
None needed.

Relevant Deadlines

Must be included in MET version 12.0.0 to be fixed for EVS version 2.0.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Review default alert labels
  • Select component(s)
  • Select priority
  • Select requestor(s)

Milestone and Projects

  • Select Milestone as the next official version or Backlog of Development Ideas
  • For the next official version, select the MET-X.Y.Z Development project

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next official version
    Select: MET-X.Y.Z Development project for development toward the next official release
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
JohnHalleyGotway commented

I do note that if the first ensemble member in the list is MISSING, an ERROR with bad exit status is written rather than just a warning.

ERROR  : grd_file_type() -> file does not exist "MISSING"

Whereas if it's not first, you get a warning instead:

WARNING: process_command_line() -> can't open input ensemble file: MISSING

That's because of these lines in Ensemble-Stat and Gen-Ens-Prod. Since a MISSING ensemble member can just as easily show up at the beginning of the file list as any other location, I assume we should also update the logic to loop through the input files until it finds one that can be read.