Enhance Point2Grid to filter quality control strings with config file options
JohnHalleyGotway opened this issue · 2 comments
Describe the Enhancement
Note, the changes for this issue rename the existing point2grid “-qc” command line option as “-goes_qc”, although the old “-qc” option is still quietly supported.
While developing a wrapper for the Point2Grid tool via dtcenter/METplus#2540, a short-coming in the Point2Grid configuration file was discovered. Please see this issue comment for details. Put simply, the existing quality_mark_thresh config file option should be replaced by the obs_quality_inc and obs_quality_exc config file options supported for the Point-Stat and Ensemble-Stat tools.
Be sure to update the unit tests to demonstrate these options and update the documentation accordingly.
Time Estimate
1 day
Sub-Issues
Consider breaking the enhancement down into sub-issues.
Relevant Deadlines
List relevant project deadlines here or state NONE.
Funding Source
2782544
Define the Metadata
Assignee
- Select engineer(s) or no engineer required
- Select scientist(s) or no scientist required
Labels
- Review default alert labels
- Select component(s)
- Select priority
- Select requestor(s)
Milestone and Projects
- Select Milestone as the next official version or Backlog of Development Ideas
- For the next official version, select the MET-X.Y.Z Development project
Define Related Issue(s)
Consider the impact to the other METplus components.
- METplus, MET, METdataio, METviewer, METexpress, METcalcpy, METplotpy
- dtcenter/METplus#2540 already exists to add a Point2Grid wrapper.
Enhancement Checklist
See the METplus Workflow for details.
- Complete the issue definition above, including the Time Estimate and Funding Source.
- Fork this repository or create a branch of develop.
Branch name:feature_<Issue Number>_<Description> - Complete the development and test your changes.
- Add/update log messages for easier debugging.
- Add/update unit tests.
- Add/update documentation.
- Push local changes to GitHub.
- Submit a pull request to merge into develop.
Pull request:feature <Issue Number> <Description> - Define the pull request metadata, as permissions allow.
Select: Reviewer(s) and Development issue
Select: Milestone as the next official version
Select: MET-X.Y.Z Development project for development toward the next official release - Iterate until the reviewer(s) accept and merge your changes.
- Delete your fork or branch.
- Close this issue.
This issue is blocking dtcenter/METplus#2540.
Added logic in point2grid to filter by the obs_qty_inc/exc settings but I get a segfault whenever that code is exercised. Recommend debugging on seneca to see why the MetPointObsData::get_obs_qty(int index) segfaults. Presumably, the obs_qids array it is references is not populated... or something like that.