dtcenter/MET

Bugfix: Fix the grid dimensions used for `point2grid_cice_set_attr_grid` unit test

Closed this issue · 0 comments

hsoh-u commented

Replace italics below with details for this issue.

Unittest name: point2grid_cice_set_attr_grid at unit_point2grid.xml, but set_attr_grid="latlon 180 360 -80 -180 1 1"

Unittest command:

/d1/personal/hsoh/git/bugfixes/bugfix_2936_point2grid_gfs/MET/share/met/../../bin/point2grid \
      /d1/projects/MET/MET_test_data/unit_test/model_data/cice/iceh.2018-01-03.c00.tlat_tlon.nc \
      G231 \
      /d1/personal/hsoh/MET/test_output/bugfix_2936_point2grid_gfs/point2grid/point2grid_cice_to_G231.nc \
      -config /d1/personal/hsoh/git/bugfixes/bugfix_2936_point2grid_gfs/MET/internal/test_unit/config/Point2GridConfig_tlat_tlon \
      -field 'name="hi_d"; level="(0,*,*)"; set_attr_grid="latlon 180 360 -80 -180 1 1";' \
      -v 1

The input file has 1440 & 1080, but set_attr_grid is defined 180 & 360. They should match.

Describe the Problem

Provide a clear and concise description of the bug here.

The API initialize and reads 180 * 360, not 1440 *1080. So there are many not-initialized values which cause different output. The point2grid output does not match with the input:

The log message:

DEBUG 2: Range of data (name="hi_d"; level="(0,*,*)"; set_attr_grid="latlon 180 360 -80 -180 1 1";)
DEBUG 2:        input: 0 to 0.424151    regridded: 0 to 359.

Some re-gridded data (0 to 359) is out of the actual data range (0 to 0.424151).

input (/d1/projects/MET/MET_test_data/unit_test/model_data/cice/iceh.2018-01-03.c00.tlat_tlon.nc):
image
Regride output (/d1/projects/MET/MET_regression/develop/NB20240909/MET-develop-ref/test_output//point2grid/point2grid_cice_to_G231.nc):
image

Expected Behavior

Provide a clear and concise description of what you expected to happen here.

The re-gridded output should match with the input.

Environment

Describe your runtime environment:
1. Machine: (e.g. HPC name, Linux Workstation, Mac Laptop)
2. OS: (e.g. RedHat Linux, MacOS)
3. Software version number(s)

To Reproduce

Describe the steps to reproduce the behavior:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error
Post relevant sample data following these instructions:
https://dtcenter.org/community-code/model-evaluation-tools-met/met-help-desk#ftp

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Review default alert labels
  • Select component(s)
  • Select priority
  • Select requestor(s)

Milestone and Projects

  • Select Milestone as the next bugfix version
  • Select Coordinated METplus-X.Y Support project for support of the current coordinated release
  • Select MET-X.Y.Z Development project for development toward the next official release

Define Related Issue(s)

Consider the impact to the other METplus components.

Bugfix Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of main_<Version>.
    Branch name: bugfix_<Issue Number>_main_<Version>_<Description>
  • Fix the bug and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into main_<Version>.
    Pull request: bugfix <Issue Number> main_<Version> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next bugfix version
    Select: Coordinated METplus-X.Y Support project for support of the current coordinated release
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Complete the steps above to fix the bug on the develop branch.
    Branch name: bugfix_<Issue Number>_develop_<Description>
    Pull request: bugfix <Issue Number> develop <Description>
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next official version
    Select: MET-X.Y.Z Development project for development toward the next official release
  • Close this issue.