Bugfix Inconsistency with generating plot in METviewer vs command line
Closed this issue · 3 comments
Replace italics below with details for this issue.
Describe the Problem
A NOAA visitor/intern is experiencing issues generating line/series plots via YAML configuration files.
Expected Behavior
Series plots with varying fcst_thresh values under the Fixed Values in METviewer generates expected differences in plots. However, when setting different fcst_thresh values under the fcst_var_vals_input setting in the METplotpy YAML config file for line plot, there doesn't appear to be any differences in the resulting plots.
METviewer is using METplotpy to generate these plots, therefore the YAML configuration files may not be set up consistently with what METviewer is sending to METplotpy. The YAML config files that METviewer generates does not generate the fcst_var_vals_input setting values. This makes trouble-shooting the issue challenging.
Environment
Describe your runtime environment:
1. Machine: (e.g. HPC name, Linux Workstation, Mac Laptop)
2. OS: (e.g. RedHat Linux, MacOS)
3. Software version number(s)
To Reproduce
Describe the steps to reproduce the behavior:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error
Post relevant sample data following these instructions:
https://dtcenter.org/community-code/model-evaluation-tools-met/met-help-desk#ftp
Relevant Deadlines
List relevant project deadlines here or state NONE.
Funding Source
Define the source of funding and account keys here or state NONE.
Define the Metadata
Assignee
- Select engineer(s) or no engineer required
- Select scientist(s) or no scientist required
Labels
- Select component(s)
- Select priority
- Select requestor(s)
Projects and Milestone
- Select Organization level Project for support of the current coordinated release
- Select Repository level Project for development toward the next official release or add alert: NEED CYCLE ASSIGNMENT label
- Select Milestone as the next bugfix version
Define Related Issue(s)
Consider the impact to the other METplus components.
Bugfix Checklist
See the METplus Workflow for details.
- Complete the issue definition above, including the Time Estimate and Funding Source.
- Fork this repository or create a branch of main_<Version>.
Branch name:bugfix_<Issue Number>_main_<Version>_<Description> - Fix the bug and test your changes.
- Add/update log messages for easier debugging.
- Add/update unit tests.
- Add/update documentation.
- Add any new Python packages to the METplus Components Python Requirements table.
- Push local changes to GitHub.
- Submit a pull request to merge into main_<Version>.
Pull request:bugfix <Issue Number> main_<Version> <Description> - Define the pull request metadata, as permissions allow.
Select: Reviewer(s) and Development issues
Select: Organization level software support Project for the current coordinated release
Select: Milestone as the next bugfix version - Iterate until the reviewer(s) accept and merge your changes.
- Delete your fork or branch.
- Complete the steps above to fix the bug on the develop branch.
Branch name:bugfix_<Issue Number>_develop_<Description>
Pull request:bugfix <Issue Number> develop <Description>
Select: Reviewer(s) and Development issues
Select: Repository level development cycle Project for the next official release
Select: Milestone as the next official version - Close this issue.
Upon closer inspection of the line plotting code, it looks like the fixed_vars_vals_input setting is NEVER read in nor used by the line_series.py code! The METviewer xml code has correctly reflected the settings for the Fixed Values in the plot_fix element, which explains why the plots are correct when generated via METviewer.
Further refinement of the query logic is needed when using a config file and data produced by METviewer:
plot_20231016_201531.yaml.txt
plot_20231016_201531.data.txt
Query is returning an empty dataframe and an empty plot. Plot should look like this:
The query is having issues with the:
fcst_thresh:
fcst_thresh_2:
- NA
The issue is with the NA value.