dtcenter/METplus

Bugfix: Remove Make ARGS from GSL installation

Closed this issue · 0 comments

Describe the Problem

When using Compile_MET:
https://raw.githubusercontent.com/dtcenter/MET/main_v11.1/internal/scripts/installation/compile_MET_all.sh

MAKE_ARGS causes gsl to fail.

Expected Behavior

MAKE_ARGS shouldn't be required for GSL

Environment

Describe your runtime environment:
*1. Machine: Desktop
*2. OS: Ubuntu 22.04.2
*3. GNU

To Reproduce

Using the compile code set MAKE_ARGS= - j ## of cores

chmod 775 compile_MET_all.sh

time ./compile_MET_all.sh 2>&1 | tee compile_MET_all.log

This will cause an error with GSL.

FIX:

run_cmd "./configure --prefix=${LIB_DIR} > gsl.configure.log 2>&1"
run_cmd "make ${MAKE_ARGS} > gsl.make.log 2>&1"
run_cmd "make ${MAKE_ARGS} install > gsl.make_install.log 2>&1"

to

run_cmd "./configure --prefix=${LIB_DIR} > gsl.configure.log 2>&1"
run_cmd "make > gsl.make.log 2>&1"
run_cmd "make install > gsl.make_install.log 2>&1"

I have tested it without using make_args and MET installs properly.

Seems to be the issue. I also vaguely remember a PR for this issue once before.