less and grep can't use the preparser
nfischer opened this issue · 2 comments
Currently, less
and grep
can't take advantage of the preparser (since they're in separate modules). Here's some possible solutions:
- move
vorpal-less
andvorpal-grep
into cash - move the preparser to a separate module, and allow
vorpal-less
andvorpal-grep
to require it - since glob expansion works for these commands, we could consider moving the preparser code to be right before or right after that.
This should be resolved if cash
switches over to vorpaljs/bash-parser (since I believe that will handle all the expansion).
This should be resolved if cash switches over to vorpaljs/bash-parser (since I believe that will handle all the expansion).
@nfisher, I could help with the transition, let me know how I can help you...
@parro-it I think the most important thing right now is to just get vorpal/bash-parser solid. The next step would probably be to switch vorpal itself to rely on that parser. After that, we may want to make an extra module just for bash-like expansion (glob expansion, variable expansion, tilde expansion, etc.).
After that, we can basically say that vorpal = bash-parser + executing registered commands, while cash = vorpal + implementation of unix commands + performing shell expansion.