Refactoring to use the new ncsdk2

Question

Refactoring to use the new ncsdk2

cpagravel opened this issue 6 years ago · 3 comments

cpagravel commented 6 years ago

Hello there,

I've refactored the code to use the new ncsdk2 API. Should I make a PR?

Answer 1 · 2018-06-28T22:56:02.000Z

yes please.

Answer 2 · 2018-06-28T22:56:58.000Z

do you have an easy way to switch to the new ncsdk2 API? Or will it detect the hardware automatically?

Answer 3 · 2018-06-29T14:43:06.000Z

I'm not sure I understand what you mean by "detect the hardware automatically".

Perhaps you're referring to detecting which version of the API is installed? In that case, no, I don't. It is possible to determine the API version from regex'ing the copyright year in the output of mvNCCheck. (2016 is version 1 and 2017 is version 2). Though I think a nicer solution would be to make a tag with support for ncsdk version 1.

I will make a pull request and you can have a look for yourself. Maybe you have a better implementation in mind.