duboviy/dist

Magic numbers ?

kounkou opened this issue · 3 comments

kounkou commented

Hey Duboviy,

I find your projects awesome !
Would like to participate a bit.
Why using those magic numbers here ? Seems to me that we can make that code more generic right ?

dist/src/py2/dist.c

Line 28 in dc41696

dist = dist * 60 * 1.1515 * 1.609344;

duboviy commented

Hi Jacques,

Totally agree.
Kindly ask you to create a pull request if functionality is not broken, I'll review and merge it.

  • 👍1
kounkou commented

Hi Duboviy,

Perfect, I added a first PR #4
In that first PR, I removing the hard coded constants and creating a new file to hold them in a
cleaner way. Let me know what you think.

  • 👍1
duboviy commented

@kounkou Nice catch and great changes! 👍 👍 👍 Thank you so much for your contribution! Feel free to create more PRs here and also within other repos. I really appreciate it, Jacques!