Update Clap to v3.2

Question

Update Clap to v3.2

ducaale opened this issue 2 years ago · 6 comments

~~n anticipation of the next major version, Clap v3.2 deprecated many existing APIs. Therefore, It would be beneficial for us to update early so we can provide early feedback regarding the new APIs.~~

See https://epage.github.io/blog/2022/06/clap-32-last-call-before-40/

Update: Clap v4 has been released, see https://epage.github.io/blog/2022/09/clap4/

Answer 1 · 2023-01-10T15:18:47.000Z

Would you like to update to clap v4?

Answer 2 · 2023-01-10T19:07:32.000Z

@gautamprikshit1 Unfortunately, clap v4 requires rust 1.64 which is too high for us at the moment. We might reconsider raising the MSRV once reqwest or another essential dependency raises their MSRV.

Answer 3 · 2023-05-17T20:59:54.000Z

Update: The MSRV has been raised to 1.64, so we should be able to upgrade clap to v4 as soon as #269 is merged.

Answer 4 · 2023-05-30T09:04:30.000Z

Please let me know when clap 3 PR is merged

Answer 5 · 2023-09-09T10:57:42.000Z

Thanks @gautamprikshit1 - There were a lot of moving parts so I went ahead and updated Clap to v4.0. However, you can still help us with upgrading to v4.3 and that would be greatly appreciated.

Answer 6 · 2023-09-09T10:59:18.000Z

It might take a while as I already have another issue assigned in other project for this weekend, next weekend for sure