duckduckgo/ios-search-and-stories

Landscape empty states outside viewport

Closed this issue · 4 comments

thm commented

In landscape, empty states seem to fall outside the viewport, with no way to scroll the last line into view.
screenshot

Can you change the margins slightly based on the comparison below, with one addition for landscape mode: in landscape mode, the entire block should be moved up an extra 40px/20pt to make it properly vertically centered. Even better would be to have it vertically centered automatically, so that it works on iPhone 5< screen sizes seamlessly, larger sizes (iPhone 6+, iPad) aren't necessarily of concern since everything would be in view there.
measurements

@thm this should be all set now

thm commented

@sreilly rather than moving the icon, title and description closer together as described above they seem to have moved even further apart. Instead of adding 10px/5pt above and below the title can you subtract that amount above and below the title so these elements get closer together?

@thm oops... I'm not sure how that happened. I've tweaked it to match the design above, with the exception of the icon + title + subtitle being vertically centered in the view. I did that to be consistent depending upon orientation, however it can definitely be tweaked. Anyway, fixes have been pushed :)

thm commented

@sreilly thanks, this works for now