duckduckgo/tracker-radar

Duplicate yjtag.jp domain within entities

damieng opened this issue · 3 comments

damieng commented

It would appear that Privacy Grade and other tools are expecting a domain name to map to a single entity in order to display data, consider if a tracker is first-party etc.

Unfortunately during this PR the yjtag.jp domain got duplicated into two different entities - "Yahoo Japan" and "TransUnion LLC".

Right now with the way Privacy Grade builds its internal lookup hashset whichever entity it reads last wins - so in this case probably the (presumably incorrect based on WhoIs for yjtag.jp) "TransUnion LLC".

I suspect the fix is simply to remove yjtag.jp from them.

kdzwinel commented

Thank you Damien for reporting and analysis of the issue, this is great. @dharb we should fix it to be "Yahoo Japan" right? I'll create an internal task for us to check if domain is not double-assigned on each PR.

damieng commented

Thanks for the prompt response! I can confirm this is the only duplicate in the data so far but yeah having a task/action that prevents future ones would be keep it in check.

  • 👍1
dharb commented

Thanks for catching @damieng! I've since added a step to the script I use to make entity updates that checks newly added domains for duplicate assignments (not the first time this has happened), but this PR must have happened before that change.

I'll include a fix in the next entity update I push.

  • 👍1