duffey/spicetify-star-ratings

Extension Not Working Properly

Closed this issue · 6 comments

This latest update appears to have broken the extension, even after re-applying Spicetify.

I managed to get it working again by removing the extension, closing Spotify, launching and re-adding the extension...but then I started getting some pretty nasty performance issues within playlists (that also gets much worse over time).

I'm really sorry about that. I published a version that did not properly package the Redux library I switched to. I have since published a working version, but it also had a bug. I just now fixed that bug. Hopefully it will be in the Marketplace soon.

If you can, please let me know if the Marketplace version works or does not in the next day.

You can also always get the super-latest version by cloning this repo and using the version in the "dist" folder.

Alright, so now the stars are appearing correctly. However, the the lag in playlists is still present.

Without the extension active, my ~800 song playlist is smooth when moving songs/scrolling/moving my mouse.
With the extension active, once I've scrolled a bit, everything starts becoming very slow. Highlighting songs when moving around the mouse becomes very laggy, and moving songs in particular becomes extremely delayed.

Some more testing, when scrolling around in a 26 song playlist, the lag never occurs.
But once I move to a larger playlist and scroll to the point where it has to load more songs, the lag starts immediately. The lag continues to be present, even in the 26 song playlist, until I restart Spotify.

Sounds like there is a memory leak. Sorry! I will look into it.

I fixed one obvious bug but it did not seem to fully resolve the problem. It seems the React state is not being properly cleaned up. I've rolled back all changes to the last good release. Unfortunately, this means the ability to rename playlists has been removed temporarily. Sorry about this.