duosecurity/duo_client_python

Tests are failing because actual requests are being made

AaronAtDuo opened this issue · 1 comments

Description

The AccountsAdmin tests are failing with SSL errors. This seems to be because of https://github.com/duosecurity/duo_client_python/blob/master/duo_client/admin.py#L3533 where a second client is spun up to look up some account details. This internal client is thus able to make actual API calls during the tests, because the client mocking set up in the tests will not affect it. Some recent change has triggered SSL errors on this internal client copy thus failing tests.

Expected Behavior

Tests should pass, ideally by consistently mocking client connections

Actual Behavior

Tests fail because they actually attempt to contact example.com

Steps to Reproduce

Run tests

Workarounds

None

Fixed by PR 252