namer is not optional any more
oleg-andreyev opened this issue · 1 comments
oleg-andreyev commented
Bug Report
| Q | A |
|---|---|
| BC Break | no |
| Bundle version | 2.2.0 |
| Symfony version | 6.3.x |
| PHP version | 8.1.x |
Summary
Done upgrade from 1.23.1 to 2.2.0.
We're getting A namer must be configured.
After searching the code found that \Vich\UploaderBundle\Mapping\PropertyMapping::getUploadName is now throwing exception if namer is not configured.
Based on diff
There was a warning but for some reason it was not tracked.
But anyway namer should be a required field so that Symfony Cache won't build.
Current behavior
namer is optional in configs.
Expected behavior
namer is not optional in configs and container complications failes.
garak commented
It seems that we're missing a call to isRequired inside our Configuration class.
Do you mind opening a PR to fix it?