dvershinin/lastversion

verify flag for sessions

eFAILution opened this issue · 3 comments

requests etc. often include options for ssl_verify and the such for those instances when the host server doesn't support. Would be convenient if your sessions adopted the same functionality. For this gitlab session it would be return self.get(url, verify=False)

return self.get(url)

I'm not sure what you mean there. Do you just want to disable TLS verification for all GitLab requests? Doesn't seem like a good thing to do.

I'm not sure what you mean there. Do you just want to disable TLS verification for all GitLab requests? Doesn't seem like a good thing to do.

Not disable by default, but give the option to. Not everyone has TLS set up on their private Gitlab instances. It’s why requests has an argument for verify.

Wouldn't it be a better option to import the root CA which issued the self signed TLS certificate, on your system?