dvorka/hstr

Broken output which could lead to a disaster

xidiot opened this issue · 9 comments

xidiot commented

Hey,

I'm using macOS Ventura 13.5 (22G74) and latest hstr available on homebrew:

$ hstr --version
hstr version "3.1.0" (2023-04-18T08:50:00)

hstr config:
export HSTR_CONFIG=hicolor,raw-history-view,keywords-matching,blacklist

I've tried with different variations of the config (removing, hiclor, keywords-matching etc.) but issue was still present.

I absolutely love hstr, but it seems it is broken on this OS (or maybe I'm the only one having this issue?), because as you can see in the below 2 videos when I search for a command the output is not correct, broken, not rendered correctly etc. which could be dangerous and it is quite confusing.

I've tested 5 (or more) different terminals (Terminator, iTerm2, Terminal, WezTerm, Warp), but in all of them I face this issue. It doesn't matter the size of the terminal or the shell (tested both zsh, bash).

REC-20230817084726.mp4
REC-20230817085016.mp4

If any other information is need please let me know.

mattklein123 commented

FWIW, I'm seeing this also, and I believe this started with the 13.5 update. It was working fine previously. I've also fiddled with various settings and have not found any way to fix.

  • 👍3
AndiDog commented

I have the same issue. First thought it's for iTerm only, but then figured out a minimal reproducible example which also fails for other terminal apps. See all info here: https://gitlab.com/gnachman/iterm2/-/issues/11054.

Since two older hstr versions also fail, I agree that it could have a relation to the macOS upgrade to Ventura 13.5.

  • 👍1
fharper commented

I thought I was going crazy when selecting a command I want to use, and having a different one executed until I took the time to check the final output after selection, and yeah, I have the same issue.

I'm on macOS (Ventura) 13.5.2 build 22G91 on arm64 if this can help find the problem.

  • 👍1
xidiot commented

I think updating to Sonoma fixed the issue, but I'll monitor it a day or two.

  • 👍2
PPACI commented

I also have the same issue on macOS ventura.
I took the habit of pressing the down arrow for a long time to "refresh" the screen.
But this is ... suboptimal.

  • 👍1
maurotdo commented

Same here, macOs ventura on apple silicon (m2)

fharper commented

Updating to Sonoma also fixed the issue for me.

xidiot commented

As others mentioned - issue is fixed after upgrading to Sonoma.

maurotdo commented

I'm quite baffled that all you can do to fix this issue is to say "upgrade to Sonoma". For the people who can't do this, i have two quickfixes:

  • brew uninstall hstr
  • or simply comment out
export HSTR_CONFIG=hicolor       # get more colors

in your shell configuration file. You will get less colors and a working hstr