dwyl/image-classifier

Error deploying due to `toastify-js`

LuchoTurtle opened this issue · 5 comments

LuchoTurtle commented

More context in https://github.com/dwyl/image-classifier/actions/runs/7260046156/job/19778403428.

The deploy script is not working because of toastify-js.

ndrean commented

Probably stupid question: did you run pnpm add toastify-js? in the assets ? Esbuild should pick-up the package.json

  • 👀1
LuchoTurtle commented

I did, which is why this is strange. This fails when running mix assets.deploy, which works on my computer O.o

toastify is in the package.json, as per

image-classifier/assets/package.json

Line 3 in b8507c2

"toastify-js": "^1.12.0"
.

Weird stuff...

I'll take a look at it once I finish #31

  • 👍1
ndrean commented

Package.json and node_modules yes. I added it, imported it in App.js, and don't get a warning with mix phx.server nor assets.deploy (locally). I did not try running the app locally as a Docker image though.

Check the version in "config.exs"? Yours is "0.14.41", and the update is version: "0.18.6", and your mix.exs is ok.

  • 👀1
ndrean commented

Update your version to "0.18.6" and use pnpm instead of npm (it's full of bugs, really). I ran your code and had the same pb as you.
Once you have pnpm installed, run in /assets pnpm add toastify-js. That's it.