Run tests on CLI/CI ?
nelsonic opened this issue · 7 comments
Run the tests on CI so we can independently confirm they are working?
Tests working in CLI:
For reason.some() not getting coverage for the calback function ... 🤔
Click even is not being triggered in JSDOM...
http://stackoverflow.com/questions/21325392/dispatch-click-eventon-jsdom-with-javascript
😢
Tried http://stackoverflow.com/a/27557936/1148249 didn't work.
The click even does not work.
I've spent way too long on this now. ⌛️ 😞
Calling it a day as the CLI test is a "Nice to Have".
If anyone else knows more about JSDOM and has some time to make the click() tests work, please go for it! 👍
The status of this issue is that CI is working. ✅
However, I was unable to get JSDOM to trigger a "Click" event for the increment/decrement/reset buttons. see: https://github.com/dwyl/learn-elm-architecture-in-javascript/blob/master/test/test.js#L66
if anyone knows JSDOM well and wants to help get the test coverage up to 100%, please go for it!
New version of JSDOM appears to have fixed the the Click events!!
Not that there are any release notes in the GitHub release: https://github.com/tmpvar/jsdom/releases/tag/11.0.0
But there appear to be in: https://github.com/tmpvar/jsdom/blob/0f4128dabbf155160eceae50a2217572439a631e/Changelog.md#1100 woop!
The internet provideth! 🎉