dxatscale/sfpowerscripts

Work Item Filters Does not work with multiple filters

brandonmikeska opened this issue · 3 comments

Describe the bug
When attempting to use workItemFilters for change logs, if you try to use multiple filters, it puts them all as one comma separated filter.

To Reproduce
Add multiple filters to your release definition.

Expected behavior
When the WorkItemUpdater is attempting to match the filters, the for of should loop the filters instead of just always finding one filter.

Screenshots
N/A

Platform Details (please complete the following information):

  • OS: Mac/Windows
  • Version [e.g. CLI Version eg: 1.6.6]: Latest
  • Salesforce CLI(sfdx cli) Version: Latest
  • CI Platform: GitHub

Additional context
This line

workitemFilters.push(releaseDefinition.changelog?.workItemFilters);

Currently is:
workitemFilters.push(releaseDefinition.changelog?.workItemFilters);

Could be changed to:
workitemFilters.push(...releaseDefinition.changelog?.workItemFilters);

I don't have access to create a branch for a pull request but I think if you do this and update the WorkItemUpdater.test.ts to have two string values it should cover the code and a good test to see it not work before this change.

@brandonmikeska you can create a PR from a fork, please feel to create one!

Thanks @brandonmikeska , its merged