dxc-technology/halstack-react

Control, maxWidth in the DxcDialog

Closed this issue · 5 comments

Describe the bug
A clear and concise description of what the bug is.
Controlling the maximum width of a dialog ensures that it doesn't become too wide, maintaining readability and aesthetic
alignment within your application's layout.

The dialog size in the one page is different from that of dialog in next page(pagination).

To Reproduce
Include steps to reproduce the behaviour.

Add Table(with pagination) with different row/column dynamic sizes within DxcDialog.
Navigate between the pages, and the DxcDialog, will resize.

For more information, please refer the below story.
https://jira.dxc.com/browse/OCARTS-88

Example:

  1. Create a new React app using Vite.
  2. Install @dxc-technology\halstack-react package.
  3. Click on '...'.
  4. Scroll down to '...'.
  5. See the error.

Expected behaviour
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

Add labels
Add any applicable label like the concerned components or the target version of the Design System where the bug has been found.

Thank you for opening an issue! 🚀

Our team will review it as soon as possible. In the meantime, please make sure that you've provided all the necessary details to help us understand and address the issue effectively.

Feel free to contribute and participate in discussions!

Hello @akhilrangu!

We will review this requirement because we are not sure if it is a fair request or if the current behaviour is correct. We will keep you informed.

Thank you for your comments and your patience.

Hello again!

After some discussion, we have decided that the Dialog is working as expected. By default, the dialog is as large as its content, setting only a maximum width and a minimum width depending on the screen's dimensions. So, for your case, you should define the width at Table level! If you want to stay consistent with the width of your dialogs, set the same size for every table with a DxcContainer or as you wish.

If you have any more doubts, please reach us!

This issue is stale because it has been open for 15 days with no activity. If there are no further updates or modifications within the next 15 days, it will be automatically closed.

This issue has been closed as it has been inactive for 15 days since being marked as stale.