Voting Post-Submission "View Results" button
Closed this issue · 7 comments
The generated hyperlink in the line:
Your votes were successfully submitted! View Results
which appears after submitting a vote, links to a blank page. An identical url with an added forward slash character takes the user to the intended page.
Issue may be solved if line 170 of submit.php is modified so there is a forward slash before the end of the <a> tag:
<a href="/results/' . $bracket->perma . '/">
Got a bracket to repro? It's known to fail for eliminations because there's no bracket to show.
Here is a freshly submitted vote on a current bracket today, with the url (bottom-left) generated for the 'View Results' button.
The given link leads to a blank page thusly.
Bizarre... Currently on holiday. Will check it out when I get back. You
might try throwing "flushCache" in the query string and see if that clears
it up
On Friday, September 2, 2016, Edward Hummerston notifications@github.com
wrote:
[image: image]
https://cloud.githubusercontent.com/assets/11281628/18222321/6ae08bd4-71d7-11e6-826f-1554379b010a.png
Here is a freshly submitted vote on a current bracket today, with the url
(bottom-left) generated for the 'View Results' button.
[image: image]
https://cloud.githubusercontent.com/assets/11281628/18222330/d3a6ab76-71d7-11e6-908a-c49f66a63044.png
The given link leads to a blank page thusly.—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#15 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA6AeMGt0PQZincbbnU3TUWjJCx7W6Jlks5qmOVigaJpZM4JzqNz
.
Matt Hackmann
http://www.dxprog.com/
I have the exact same issue, adding a / to the result url fixes it.
Example:
https://animebracket.com/results/best-girl-4-a-certain-salty-railgun returns blank page, like so:
https://animebracket.com/results/best-girl-4-a-certain-salty-railgun/ works as expected.
The returned html is exactly the same for the above example, so I'm guessing the issue is somewhere in the js. /vote does handle urls with or without the trailing /, so /results should handle it as well, if only for consistency.
The rendered page doesn't have the Patreon banner or the link to Github, unlike nonexistent bracket names like https://animebracket.com/results/not-a-real-bracket/ or https://animebracket.com/results/not-a-real-bracket.
Both of these nonexistent bracket urls show the same page for me, a blank result page but they do show the Patreon banner and the Github link, like so:
Browser is Firefox 45.9.0 on Linux
Thanks for the detailed info! Should be able to roll out a fix pretty quickly.
With and without trailing slash should be working correctly, now. Hoping I didn't regress something else in the process...