dy/gl-waveform

webpack and webworkify

meandavejustice opened this issue · 3 comments

This module doesn't work with webpack because of the webworkify dependency.

In order to get it to work, line 26 in create-storage.js needs this adjustment

let worker = workify(require('./worker'));
let worker = workify(require.resolve('./worker'));

Along with requiring webworkify-webpack instead of webworkify.

It would be nice if support for both could be added, though the extra dependency is annoying...

dy commented

Awesome, thanks for the PR!
In the meantime I think I got a new method of getting waveform stats O(c), so we can get rid of webworker at all. Please stay tuned!

@dfcreative Woah awesome! looking forward to seeing that

dy commented

With new bundle it works.