dymensionxyz/dymension

Panic on nil dereferences if `UpdateRollappPacketWithStatus` errors

omritoptix opened this issue · 0 comments

In x/delayedack/rollapp_hooks.go:106-110, the rollappPacket variable is
modified within the UpdateRollappPacketWithStatus function and later used for
loggings if an error occurred.
This is problematic because the UpdateRollappPacketWithStatus function sets the
rollappPacket variable to commontypes.RollappPacket{}, which causes a nil
deference error and a runtime panic when rollappPacket.Packet.GetSequence() is
called.
This issue is also present in x/delayedack/keeper/fraud.go:39-43.