dyrector-io/dyrectorio

Refactor agent image url parse helper unit tests

nandor-magyar opened this issue · 3 comments

nandor-magyar commented

We have unit tests spread across various functions, but some/most of them could be organized into table driven test cases.

Refactor the tests into table driven ones where it is applicable in the file:
golang/internal/helper/image/image_unit_test.go

An example could be seen in golang/internal/runtime/container/container_test.go function TestVersionCheck.

PapePathe commented

Hello can i self assign this issue ?

polaroi8d commented

Hi @PapePathe for sure. If you have any questions please ask us. I've assigned the issue to you.

  • 👍1
PapePathe commented

Hello @polaroi8d i just opened a PR. Let me know how you feel about it.