dzcode-io/dzcode.io

migrate mobile common components to `@dzcode.io/ui-mobile`

omdxp opened this issue · 3 comments

omdxp commented

migrating mobile common components to @dzcode.io/ui-mobile

  • AppBar
  • DrawerContent
  • ErrorBoundary
  • Loading
  • TryAgain
ZibanPirate commented

What's the package name gonna be? @dzcode.io/mobile? @dzcode.io/ui-mobile? @dzcode.io/mui🙃? Or what?

omdxp commented

I thought it'll be @dzcode.io/mobile since it'll contain some other sub packages other than ui, maybe hooks, utils ?

ZibanPirate commented

That's an interesting approach, so the ui package will be in ./packages/mobile/ui/package.json, then later we can add other packages that are consumed by mobile only in ./packages/mobile/[another mobile only package name]/package.json

And we import them like:

import { Button } from "@dzcode.io/mobile/ui/dist/button"

I'm fine with that.

One important note, make sure to first setup the package with a single simple component and consume it in ./mobile, in one PR. Once that is green, you can then continue adding the rest of the components in follow PR/PRs

  • 👍1