dziemborowicz/hourglass

Issue with "until time of day"

Opened this issue · 2 comments

sircedriclex commented

Hello, I recently encountered a small bug regarding the "until time of day" function. If the last timer was in the range of "until 12:XX:XX", Hourglass shows "until 24:XX:XX" after stopping the timer or restarting the program. As far as I know the 24-hour clock only ranges from 00:00:00 to 23:59:59. It displays the timers in "Recent inputs" and "Saved timers" as "until 24:XX:XX", too. If I start an "until 24:XX:XX" timer, there is no error and Hourglass rather interprets it as 12:XX:XX during the day (but more testing is needed if that is always the case).

Thanks for this great program!

i2van commented

Hello, I recently encountered a small bug regarding the "until time of day" function. If the last timer was in the range of "until 12:XX:XX", Hourglass shows "until 24:XX:XX" after stopping the timer or restarting the program. As far as I know the 24-hour clock only ranges from 00:00:00 to 23:59:59. It displays the timers in "Recent inputs" and "Saved timers" as "until 24:XX:XX", too. If I start an "until 24:XX:XX" timer, there is no error and Hourglass rather interprets it as 12:XX:XX during the day (but more testing is needed if that is always the case).

Thanks for this great program!

Could you describe exact steps to reproduce or create a short video?

Thank you!

sircedriclex commented

Steps to reproduce:

  • Enable "Prefer 24-hour time when parsing" under "Advanced options" (I just realized that this has to be enabled)
  • Type e.g. "until 12:34:56" without the quotation marks
  • Start the timer
  • Stop the timer (or close and restart the program)

Hourglass then shows the last timer as "until 24:34:56" (in "Recent inputs" and "Saved timers", too).
Furthermore, it is possible to start any "until 24:XX:XX" timer without an error.

I hope this helps!