Detect current branch name without external dependencies

Question

Detect current branch name without external dependencies

raehalme opened this issue 8 years ago · 9 comments

I would appreciate if this great plugin could resolve the current Git branch name without external dependencies. I'm not too happy about modifying our CI agents to set environment variables as I would like to configuration to be kept as simple and clean as possible.

One solution is to use the plugin org.codehaus.mojo:buildnumber-maven-plugin which is capable of setting the current branch name into a property (by default scmBranch). This property can be referenced in the gitBranchExpression property as long as the plugin is allowed to be executed.

Would you be willing to consider adding the plugin org.codehaus.mojo:buildnumber-maven-plugin to the set of retained plugins?

Would it make sense to make the list of retained plugins to be configurable? It would allow other similar plugins to be easily configured as well.

Answer 1 · 2017-02-02T10:48:39.000Z

Actually after testing this by retaining also the buildnumber-maven-plugin plugin the process no longer runs as intended. For example, test and compile are now again included in the build process when running on the master branch.

It would probably be best if the branch name could be resolved without the help of any other plugins (to avoid them messing up the build process). I'll have a look if we could easily incorporate the logic in buildnumber-maven-plugin to resolve the current branch directly in this plugin.

Answer 2 · 2017-02-02T12:44:53.000Z

I now have a version available which uses ScmManager and the Git provider to resolve the current branch name. Would it be okay to replace the default value ${env.GIT_BRANCH} with this implementation? You could still specify ${env.GIT_BRANCH} explicitly in the configuration, if preferred.

Answer 3 · 2017-02-02T13:55:05.000Z

Interesting. I'd be curious to see a pull request!

The reason I used '${env.GIT_BRANCH}' was that it was (hah provided) by my CI server (Jenkins), and easy to detect if it wasn't set at all (in a local developer environment)

Answer 4 · 2017-02-02T14:50:57.000Z

Sure thing! Should I target the development branch? Looks like it's a bit out of date, could you maybe update it?

Answer 5 · 2017-02-02T15:00:02.000Z

Looks like I'd managed to forget to push my local merges. Whoops! Should be all up to date now.

Answer 6 · 2017-02-02T15:09:26.000Z

Thanks! You can see my changes in #53.

Answer 7 · 2017-02-02T18:22:21.000Z

So what's funny, is that you probably could have just put..

<gitBranchExpression>${project.scm.developerConnection}</gitBranchExpression> and just ignored all the code changes. :-D ohhhh I wish I'd thought of that sooner.

Oh, wait... no that wouldn't get the branch. :-)

Answer 8 · 2017-02-02T18:30:02.000Z

Are you sure about that? Must be some weird Maven magic behind the scenes then :-)

Answer 9 · 2017-02-02T19:51:51.000Z

Yeah, it wouldn't have worked for the branch name. :-)