[Victory] Change colour of model elements in visualisation
anthonyanjorin opened this issue · 7 comments
Currently we are using the default plantuml vis for model elements. It's yellowish, however, and thus clashes with our background colour for source domain elements. Let's switch to plain white (background) and black (outline).
With a white background it looks like this:
Perhaps we should consider a brighter yellow to make the distinction more obvious?
Hmm... I can‘t decide what one wants here. I had a meeting with QA today and the feeling was that one actually would like to distinguish src and trg model elements also based on their background colour.
What do you think of using the same background colours as in the rule? I don’t think one would mix up rule and model elements....
Considering that the rule and models are seperated from each other anyways, that makes a lot of sense.
Will be more involved in terms of implementation though. As far as I'm aware, you can't extract the domain from the model objects directly, can you?
oh should be easy... just add the method to the victory interface.
The operational strategy has separate resources for each domain and just needs to do: srcResource.equals(EcoreUtil.getRootContainer(modelElement).eResource())
I've changed the visualisation to be identical to that of the rule elements.
Personally I find it works, although I do see potential for confusing rule and model elements.
The changes have been merged into the stable branches, so you can go ahead and take a look yourself.
Can this issue be closed or should we tweak the visualisation a little more?
Let’s use it like this for a while and find out.