eNkru/freelook

addressees in To: field not visible

bvdlingen opened this issue ยท 25 comments

Happy I stumbled upon this great app!

After using it a few days, I only discovered 1 minor issue:

When composing a new email or replying to an email the addresses in the To: field are not visible
They are there however; I am able to send the email

eNkru commented

@bvdlingen if I remember correct, this issue is reported by another user with deepin Linux.

Could you let me know which distribution are you using and maybe a screenshot of the issue is helping.

I really couldn't reproduce it. I reckon it's something wrong with the UI CSS

Thanks for the follow up,

I am running Solus Linux, with Budgie desktop (based on GTK3)
The issue occurs on both work and private notebooks and desktops.

See this screenshot to illustrate the behaviour:
https://i.postimg.cc/434B7br3/Screenshot-from-2020-01-09-15-55-32.png

Making the screenshot I noticed the following:
The problem does not occur when opening a reply to message or new message in a new window. In other words it only occurs when sending (compose and or reply) an email within the main window.

I didn't test on other linux desktop environments, I can do this is this is helpful

ps:
Don't know if this is relevant at all: Deepin desktop environment is based on Qt, not on GTK like Solus Budgie

I did some additional testing:

  1. office 365 theme settings don't make a difference
  2. office 365 display density settings don't make a difference
  3. behaviour occurs with both prebuild appimage and self build appimage
eNkru commented

@bvdlingen thanks for the feedback.

Could you run the app by using yarn start or npm start, and check if the issue still occur? then check if the terminal throw any error or the build in developer tools (contrl + shift + i) throw any error in the console? another testing is using Chrome with the web version, see if that also have this issue.

I am working wit the GNOME 3 and KDE plasma every day. Seems fine by me.

eNkru commented

I reckon you will have the same issue in yarn start, but the chrome web all good.

That's what's been feedback by another user long times ago.

Wow that's interesting!

I didn't try that before, but when using yarn start the issue does not occur.
Hence no error in the terminal.

A colleague running Debian + Gnome had the same issue, will ask him to try yarn start too.

eNkru commented

That's strange. I used to work on the Ubuntu + Gnome and it was all good. Now I am switching to Fedora + Gnome 3, still couldn't reproduce the issue.

If yarn start doesn't have the issue, then the problem might caused by the Election builder when build the AppImage (some magics).

Another try is using the .deb package if you are on the Debian. Not familiar with Solus, see what package can supported by Solus in the Election builder. Then you can tweak the package.json a little bit to build your executable.

Another try can be upgrade the Electrion builder to the latest (22.2.0), currently it's on 20.x.x

The same problem happens on my Ubuntu 18.04 installation.

Hi!

Awesome tool, came here to report that this issue also happens on Manjaro 18.1.5 with Cinnamon.

eNkru commented

really keen to fix this. as I couldn't reproduce this issue. appreciated if someone can always reproduce this issue find the root cause for me? to debug this issue, best run the app from the source code with npm run start or yarn start. The console will remain open to throw any error if occurred. also the developer tools of build in chromium can be enabled. see if any error in the console.

I reckon this issue is caused by javascript or css issues in chromium on particular platform.

really keen to fix this. as I couldn't reproduce this issue. appreciated if someone can always reproduce this issue find the root cause for me? to debug this issue, best run the app from the source code with npm run start or yarn start. The console will remain open to throw any error if occurred. also the developer tools of build in chromium can be enabled. see if any error in the console.

I reckon this issue is caused by javascript or css issues in chromium on particular platform.

Just tried on a vm with Manjaro 18.1.5 with Cinnamon I have at home, reproduced the issue running directly from source but no error in console ๐Ÿ˜•

eNkru commented

really keen to fix this. as I couldn't reproduce this issue. appreciated if someone can always reproduce this issue find the root cause for me? to debug this issue, best run the app from the source code with npm run start or yarn start. The console will remain open to throw any error if occurred. also the developer tools of build in chromium can be enabled. see if any error in the console.
I reckon this issue is caused by javascript or css issues in chromium on particular platform.

Just tried on a vm with Manjaro 18.1.5 with Cinnamon I have at home, reproduced the issue running directly from source but no error in console

according the feedback, the email can be still send to the correct contact. So I reckon it's just a UI rendering issue. The contact is not visible in the right place.

If you familiar with the HTML and CSS, probably can find out why it's not visible from the follow source code.

image

I didn't customize that part of logic though. One possibility is due to the app hide the ads on the right side. This might change the layout a little bit and may cause that contact div shift to somewhere else.

Really need to drill into the root cause, so can be a fix.

eNkru commented

another thing to verify my guess is remove the vertical ads class value in setting and restart the app.

You will see the long vertical ads bar on the right side. Then check if you still having the issue :)

another thing to verify my guess is remove the vertical ads class value in setting and restart the app.

You will see the long vertical ads bar on the right side. Then check if you still having the issue :)

Ah!, I see, you may be on to something, I just set another class name for all ads and the issue no longer reproduces, both on the latest AppImage and from source.

I'm at an enterprise office365 subscription so no ads. Maybe that's why you can't reproduce it?

eNkru commented

another thing to verify my guess is remove the vertical ads class value in setting and restart the app.
You will see the long vertical ads bar on the right side. Then check if you still having the issue :)

Ah!, I see, you may be on to something, I just set another class name for all ads and the issue no longer reproduces, both on the latest AppImage and from source.

I'm at an enterprise office365 subscription so no ads. Maybe that's why you can't reproduce it?

Thanks for trying out. I reckon we make some progress onto this. I'll change the way handling the ads blocker in the next few days.

Hi all,

any update on this? Just a confirmation that it also happens for me and I'm using a corporate Outlook subscription. So must have something to do with the logic to hide the ads. It is a little bit frustrating and can lead to e-mails being sent to unintended recipients.

Best regards,
Dominic.

eNkru commented

Hi all,

any update on this? Just a confirmation that it also happens for me and I'm using a corporate Outlook subscription. So must have something to do with the logic to hide the ads. It is a little bit frustrating and can lead to e-mails being sent to unintended recipients.

Best regards,
Dominic.

Hi @dcioccarelli, thank you to support the app.

There is a workaround for this issue. If you are using corporate outlook subscription, there shouldn't be any vertical ADs unit on the right side. What you can do is adding a invalid class name into the setting. The VERTICAL ADS CLASS is the one you looking for. Just type some random number inthere will do :)

image

Please leave some feedback see if this will fix your problem :)

I can confirm that the workaround works for corporate outlook subscription. maybe add a note to the readme?
also add a note that to access the settings window right click on the system tray icon, (took me a good hour to find)
OS: ubuntu 18.04 LTS

Hi @eNkru ! It worked. At first I just added random text in the vertical ads class and it didn't work. Only when I had added it to all three classes did it work.

Maybe add a checkbox to the UI for corporate users which automatically adds random text and disables the text entry boxes?

eNkru commented

I can confirm that the workaround works for corporate outlook subscription. maybe add a note to the readme?
also add a note that to access the settings window right click on the system tray icon, (took me a good hour to find)
OS: ubuntu 18.04 LTS

Thank you for the confirmation. I'll update the README

eNkru commented

Hi @eNkru ! It worked. At first I just added random text in the vertical ads class and it didn't work. Only when I had added it to all three classes did it work.

Maybe add a checkbox to the UI for corporate users which automatically adds random text and disables the text entry boxes?

I'll re-arrange the setting panel layout for easy use :)

eNkru commented

Finally this issue should be fixed. I couldn't reproduce the error anymore.

011c894

Feel free to re-open this ticket if you still having the issue.

Adding invalid class to first field only doesn't do it for non-corporate accounts (hotmail.com) on ubuntu 18.04, but I added in all 4 fields and it seems to do the trick!

eNkru commented

Adding invalid class to first field only doesn't do it for non-corporate accounts (hotmail.com) on ubuntu 18.04, but I added in all 4 fields and it seems to do the trick!

could you try my last commit. It should fix the issue and you don't need to do this workaround anymore.

Confirmed last commit fixes with 0 such field change, cheers!