eWaterCycle/era5cli

Availability of ERA5 data from 1959

Closed this issue · 5 comments

Hi,

I used era5cli installed from conda-forge (v1.3.1). I've noticed that one can download only the data back to 1979, although the product is available from 1959. I manually tried changing the earliest year in https://github.com/eWaterCycle/era5cli/blob/main/era5cli/cli.py#L350 to 1959 and the request went through. Should I submit pull request changing it?

Cheers!

Hi @malininae, thanks for the issue! Indeed, the back extension with data <1979 is available now, but we have not yet updated this tool. If you are interested in contributing, this would be very welcome!

(Related: #115)

@bvreede Thanks, I'm happy to contribute! I tried to create a new branch, but got following mistake:

remote: Permission to eWaterCycle/era5cli.git denied to malininae. fatal: unable to access 'https://github.com/eWaterCycle/era5cli.git/': The requested URL returned error: 403

Do I need some special permissions? Could you grant them to me?

Hi @malininae thanks, that was fast!
You don't need to create a branch to make a pull request, not to worry. You can make a fork of the repository to your own account, and make your edits there where you have full permission, then make a pull request from the fork.

I have opened a new branch on this repository: back_extension_update; could you make your pull request onto that branch? That would allow us to add further edits if necessary before merging it to main.

See screenshot below: when making the PR, instead of base: main, select base: back_extension_update.

Screenshot 2022-09-29 at 06 33 12

Thanks so much for the PR @malininae! I'll get to it ASAP :)