info button does not work on webkit browsers
duncdrum opened this issue · 7 comments
the blue info button does not expand and display the panel as expected, it works in firefox.
tested with Safari 11.1.1
and Chrome 67.0.3396.87
Of course i tested this with mentioned browsers but will check again tomorrow.
@duncdrum Can you share a screenshot? what about a 'show details/errors' list from the dev tools in the browser?
Video uses safari tech preview (no plugins). Tested on 4.2.1 and 5.0.0-RC1, all tests on macOS 10.13.5.
I don't think the favicon warning is it, the missing webcomponents-lite.js.map could be to blame.
The warning of screen is:
[Deprecation] The “vaadin-valo-styles” (previously named “vaadin-valo-theme”) package is deprecated. Please migrate to the “vaadin-lumo-styles” package. See "https://github.com/vaadin/vaadin-valo-styles/blob/master/README.md" for more information.
@JoernT have you considered sauce labs to specify an array of supported browsers for testing? How about wct.conf.json as recommended by the polymer2 docs for testing webcomponents.
seems to be a regression. Pretty sure it worked. Neither of the above warnings will be responsible. I think it's an event-handling issue. Will have a look.
@duncdrum sourcelabs won't help a lot as there are no tests yet ;) Further this kind of issue is not new to me. There are differences between FF and Chrome/Safari with respect to event-handling that nagged me before but the cause is the differences in shadowDOM implementations. This is likely going away soon as FF will roll out shadowDOM in the very near future.
But of course i'd like to add tests anyway when i find the time.
arrgh - it's worse. It is NOT the event-handling but the different handling of CSS matchers - still investigating...
I'm stuck with this issue at the moment. Seems it's a kind of refreshing problem with CSS. When the icon is clicked an attribute is set on a wrapper element which should fire a CSS style that makes the subitems visible. For some reason this not working (any more). Maybe the and it's descendants don't have the best design and it needs a rewrite but that would be a larger effort. Still hoping for an easier fix.
one step further - got it working in Chrome but not Safari.