gitkraken/vscode-gitlens

Better recognition of local GitLab installations

ffes opened this issue · 4 comments

ffes commented
  • GitLens Version: 6.2.0
  • VSCode Version: 1.18.1
  • OS Version: Windows 10

We run a GitLab CE server in our LAN and right now to open the remote I need to add this line to my settings (obviously example.com is replaced with the proper internal name ;-)

"gitlens.remotes": [{ "domain": "gitlab.example.com", "type": "GitLab" }]

But as you can see, the URL contains the part gitlab. It would be great if GitLens would automatically recognize the gitlab part in the URL and open the remote accordingly, so without the need to add the line to the settings.

And yes, when somebody chooses to use git.example.com they still would need to configure that manually.

eamodio commented

Let me think about this some more. It feels too fragile to me right now. Another option would be if GitLens detects remotes that aren't currently "built-in" that it could prompt you to setup the remote with GitLens. What do you think about something like that?

ffes commented

That would help indeed, but I still think that when somebody put gitlab in the domain name of a remote it can be safely recognized.

  • 👍2
yajo commented

Both options seem interesting. It's hard for somebody to have a gitlab.whatever that isn't a gitlab, it seems a sane default.

OTOH, right-click > define remote type would fix all possible corner cases.

github-actions commented

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.