Default Settings Get Added Automatically
rifaidev opened this issue · 6 comments
gitlens.advanced.messages defaults get appended to the end of my user settings file everytime I remove it and restart vscode.
Is that a normal behavior?
Yes, it is normal, as GitLens is keeping track of messages that should be suppressed. It is ugly that I have to store them in the settings, but I used to store them in localstorage and ran into many issues where users would report that messages kept showing up, etc (because of underlying bugs in vscode's localstorage access). Honestly I've thought about consolidating them into a single entry (bit flags, or something) but then they would be harder to manually tweak.
Thanks for your prompt response @eamodio, excuse me but I didn't understand the need for adding them to the user settings in case they are the same as in the defaults settings and I didn't customize anything?
They aren't all defaults, the suppressShowKeyBindingsNotice is set to true once you have seen it. I will think about this more to change the data format, so it is less verbose. Although, it still will add a gitlens.advanced.messages entry.
I still didn't get the idea behind injecting such configs into my user settings, while you can set wherever you see right as defaults. I hope you really think about removing it from user settings as it's very annoying!
As I mentioned, using the local-storage proved far to error prone (too many reports of users getting prompts they had dismissed, etc), so user settings were the only viable alternative.
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.