Open GH repo resets quick pick focus while browsing

Question

Open GH repo resets quick pick focus while browsing

Opened this issue 4 years ago · 6 comments

Again maybe root cause is core. This caused me to open the wrong repo:

Answer 1 · 2021-03-23T15:10:30.000Z

Hrm, I think I've seem something kind of similar. Also that search doesn't work very well either. But yeah, that is a core feature.

Answer 2 · 2021-03-23T15:11:56.000Z

@TylerLeonhardt FYI since you're jumping into quick pick soon.

Answer 3 · 2021-03-23T16:52:44.000Z

This is probably microsoft/vscode#76193

Answer 4 · 2021-03-23T17:56:42.000Z

I'd expect items to be added not removed above, if that matters

Answer 5 · 2021-04-02T04:37:22.000Z

True yeah this is different. I'm thinking the problem is, @eamodio sets picker.items and that resets the focus back to the top when really it should honor what the activated items were prior.

@eamodio can you do this for me, every time you're about to set items store the activeItems and then set activeItems after setting items. I think that'll fix the problem.

Answer 6 · 2021-04-02T04:40:30.000Z

Where is this code btw?