rethink `standardize_names` argument implementation
IndrajeetPatil opened this issue · 1 comments
IndrajeetPatil commented
Currently, setting it to TRUE makes no difference because the names are already standardized.
library(correlation)
waldo::compare(
correlation(cars, standardize_names = FALSE),
correlation(cars, standardize_names = TRUE)
)
#> v No differences
Created on 2021-11-25 by the reprex package (v2.0.1)
I think the way this should work is with the default argument being standardize_names = "easystats"
, which would be backward-compatible. And, if someone wishes, they can change it to standardize_names = "broom"
.
This lets users have a better control over the column naming style.
bwiernik commented
Good idea