ebimodeling/ghgvcR

Comment and refactor ghgvc() function

Closed this issue · 3 comments

This script is pretty much a direct translation of the original matlab code.

Other items on the list:

  • Test ghgvc_plot() and ghgvc_write() use in src/ghgvc_script.R once ghgvc and ghgvc2 rewrite is done.

@dlebauer Nearly done with the last couple of points in this issue. Hoping to wrap that up with a few more hours of work. I'm at about 11 right now. I've significantly reduced the unnecessary code, repeated allocation of matrices where not needed, looping as opposed to the use of lapply, etc... Seems much cleaner. I'm hoping by Saturday I can make a working commit that will pass the test script.

Closing, moving the renaming to a separate issue to deal with later.