ebonnecab/Core-Data-Structures

Feedback: Number Bases & Search Algorithms

Closed this issue · 0 comments

  • Nice work on you number base functions. I would've liked to have seen some comments that explain what some of the lines of code were doing as if I had wasn't familiar with number base conversion (what is the process inside your functions and why is it like that?).
  • Your binary search functions are good as well. I couldn't see anything major that needed fixing; something small that could be fixed is using a linter and to enforce consistent styles. My Flake8 linter was catching some inconsistent styling like the space between midpoint and the minus sign on line 79, and the space between the commas and left on line 80.