ebonnecab/Core-Data-Structures

Feedback on Palindromes and String Searching Algorithms

Closed this issue · 0 comments

Good work on getting your palindromes tests passing. The helper function to clean your text is a good idea, but it increases both your time and space complexity before you even check if you have an empty string. Also, it eliminates the possibility of checking early on if the given text is a palindrome and exiting early before altering the string.

The test that is failing in your strings_test.py was not written correctly. Refactor the test and everything should pass. You haven't yet refactored to avoid duplication and you need to annotate your time and space complexities.