ebtc-protocol/ebtc

Pls fix TODO

Opened this issue 8 months ago · 4 comments

GalloDaSballo commented 8 months ago

https://github.com/Badger-Finance/ebtc/blob/a71f8700161843b72152fda0837d6e7fd9571ff0/packages/contracts/contracts/Governor.sol#L184-L185

https://github.com/Badger-Finance/ebtc/blob/a71f8700161843b72152fda0837d6e7fd9571ff0/packages/contracts/contracts/HintHelpers.sol#L102-L103

dapp-whisperer commented 8 months ago

@rayeaster can you look into the HintHelpers todo?

dapp-whisperer commented 8 months ago

since these are periphery contracts - it is ok to change them imo

rayeaster commented 8 months ago

This seems to return the original coll? why?

It is already removed by this commit 0c5e633#diff-18e13a47d3af478990ec346c6f96036d8fb11a10e64cdb22f0c4aba5a4601955L102

rayeaster commented 8 months ago

similarly for mentioned "TODO" in Governor f5cebe6#diff-3d5d930a9c7a520ba4588c2cd84e726097b944adbf1058cccd50b43e374c54c8L184