echemdb/svgdigitizer

New version of click (8.1.0) is not compatible.

DunklesArchipel opened this issue · 2 comments

I had to fix the version number of click to 8.0.3, since 8.1.0 is responsible for the failed doctests in the previous test runs.

Originally posted by @DunklesArchipel in #145 (comment)

This is an error from the doctests:

_______ [doctest] svgdigitizer.electrochemistry.cv.CV.voltage_dimension ________
197             ...     <text x="-100" y="100">j1: 0 uA / cm2</text>
198             ...   </g>
199             ...   <g>
200             ...     <path d="M -100 0 L 0 0" />
201             ...     <text x="-100" y="0">j2: 1 uA / cm2</text>
202             ...   </g>
203             ...   <text x="-200" y="330">scan rate: 50 V/s</text>
204             ... </svg>'''))
205             >>> cv = CV(SVGPlot(svg))
206             >>> cv.voltage_dimension
UNEXPECTED EXCEPTION: ImportError("cannot import name 'get_terminal_size' from 'click.termui' (/usr/share/miniconda/envs/test/lib/python3.9/site-packages/click/termui.py)")
Traceback (most recent call last):
  File "/usr/share/miniconda/envs/test/lib/python3.9/doctest.py", line 1334, in __run
    exec(compile(example.source, filename, "single",
  File "<doctest svgdigitizer.electrochemistry.cv.CV.voltage_dimension[6]>", line 1, in <module>
  File "/home/runner/work/svgdigitizer/svgdigitizer/svgdigitizer/electrochemistry/cv.py", line 243, in voltage_dimension
    dimensions = list(set(["E", "U"]).intersection(self.svgplot.schema.field_names))
  File "/home/runner/work/svgdigitizer/svgdigitizer/svgdigitizer/svgplot.py", line 1700, in schema
    from frictionless import Schema
  File "/usr/share/miniconda/envs/test/lib/python3.9/site-packages/frictionless/__init__.py", line 20, in <module>
    from .program import program
  File "/usr/share/miniconda/envs/test/lib/python3.9/site-packages/frictionless/program/__init__.py", line 1, in <module>
    from .api import program_api
  File "/usr/share/miniconda/envs/test/lib/python3.9/site-packages/frictionless/program/api.py", line 1, in <module>
    from typer import Option as Opt
  File "/usr/share/miniconda/envs/test/lib/python3.9/site-packages/typer/__init__.py", line 12, in <module>
    from click.termui import get_terminal_size as get_terminal_size
ImportError: cannot import name 'get_terminal_size' from 'click.termui' (/usr/share/miniconda/envs/test/lib/python3.9/site-packages/click/termui.py)
/home/runner/work/svgdigitizer/svgdigitizer/svgdigitizer/electrochemistry/cv.py:206: UnexpectedException

This is a problem in frictionless. get_terminal_size had apparently been marked as deprecated for a while.