Typechecker does not apply same type inference to type functions as generic functions

Question

Typechecker does not apply same type inference to type functions as generic functions

Closed this issue 6 years ago · 6 comments

The typechecker tests fail where we have the following sort of calls:

    value pl = plus;
    Integer sum1 = [1,2,3].fold(0, plus); // OK
    Integer sum2 = [1,2,3].fold(0, pl); // FAIL

Because the new type inference that allowed the fold refactoring to pass in the first case was probably not adapted for type functions such as pl?

That's blocking the typechecker tests.

Answer 1 · 2018-02-26T11:12:37.000Z

@gavinking either this is supposed to work, and can you fix it, or it's not and I can disable those tests?

Answer 2 · 2018-02-26T11:24:28.000Z

Looks like #7251 overlooked type functions.

Answer 3 · 2018-03-29T17:33:33.000Z

OK, I will take a look.

Answer 4 · 2018-04-01T19:34:49.000Z

I have pushed a really fragile fix to this problem, and now all the typechecker tests are passing, however, I would like to come back to this and try to clean up the fix.

Answer 5 · 2018-04-03T07:42:08.000Z

Thanks. Will try it out ASAP.

Answer 6 · 2018-04-25T21:32:48.000Z

Y'know, coming back to this, my fix is really not that fragile. In fact, I guess it's no more fragile than the situation with a direct function ref. So I'm going to close this.